void TraceBuilder::constrainGuard(IRInstruction* inst, TypeConstraint tc) { if (!shouldConstrainGuards()) return; auto& guard = m_guardConstraints[inst]; if (tc.innerCat) { // If the constraint is for the inner type and is better than what guard // has, update it. auto cat = tc.innerCat.get(); if (guard.innerCat && guard.innerCat >= cat) return; FTRACE(1, "constraining inner type of {}: {} -> {}\n", *inst, guard.innerCat ? guard.innerCat.get() : DataTypeGeneric, cat); guard.innerCat = cat; return; } if (tc.category > guard.category) { FTRACE(1, "constraining {}: {} -> {}\n", *inst, guard.category, tc.category); guard.category = tc.category; } if (tc.knownType < guard.knownType) { FTRACE(1, "refining knownType of {}: {} -> {}\n", *inst, guard.knownType, tc.knownType); guard.knownType = tc.knownType; } }
/* * Returns true iff a guard to constrain was found, and tc was more specific * than the guard's existing constraint. Note that this doesn't necessarily * mean that the guard was constrained: tc.weak might be true. */ bool IRBuilder::constrainGuard(IRInstruction* inst, TypeConstraint tc) { if (!shouldConstrainGuards()) return false; auto& guard = m_guardConstraints[inst]; auto changed = false; auto const assertFits = typeFitsConstraint(guard.assertedType, tc); ITRACE(2, "constrainGuard({}, {}): existing constraint {}, assertFits: {}\n", *inst, tc, guard, assertFits ? "true" : "false"); Indent _i; // For category and innerCat, constrain the guard if the assertedType isn't // strong enough to fit what we want and tc is more specific than the // existing category. if (!assertFits && tc.innerCat > guard.innerCat) { if (!tc.weak) { ITRACE(1, "constraining inner type of {}: {} -> {}\n", *inst, guard.innerCat, tc.innerCat); guard.innerCat = tc.innerCat; } changed = true; } else { ITRACE(2, "not constraining innerCat\n"); } if (!assertFits && tc.category > guard.category) { if (!tc.weak) { ITRACE(1, "constraining {}: {} -> {}\n", *inst, guard.category, tc.category); guard.category = tc.category; } changed = true; } else { ITRACE(2, "not constraining category\n"); } // It's fairly common to have a local that we've asserted to be Obj, and then // later assert that it's Obj<C>|InitNull. We want to use their intersection, // so in this case we'd assert Obj<C>. always_assert(tc.assertedType.maybe(guard.assertedType)); auto assertCommon = tc.assertedType & guard.assertedType; if (assertCommon < guard.assertedType) { // We don't check tc.weak here because assertedType is supposed to be // statically known type information. ITRACE(1, "using {} to refine assertedType of {}: {} -> {}\n", tc.assertedType, *inst, guard.assertedType, assertCommon); guard.assertedType = assertCommon; } else { ITRACE(2, "not refining assertedType\n"); } return changed; }
/* * Returns true iff a guard to constrain was found, and tc was more specific * than the guard's existing constraint. Note that this doesn't necessarily * mean that the guard was constrained: tc.weak might be true. */ bool TraceBuilder::constrainGuard(IRInstruction* inst, TypeConstraint tc) { if (!shouldConstrainGuards()) return false; auto& guard = m_guardConstraints[inst]; auto changed = false; if (tc.innerCat) { // If the constraint is for the inner type and is better than what guard // has, update it. auto cat = tc.innerCat.get(); if (guard.innerCat && guard.innerCat >= cat) return false; if (!tc.weak) { FTRACE(1, "constraining inner type of {}: {} -> {}\n", *inst, guard.innerCat ? guard.innerCat.get() : DataTypeGeneric, cat); guard.innerCat = cat; } return true; } if (tc.category > guard.category) { if (!tc.weak) { FTRACE(1, "constraining {}: {} -> {}\n", *inst, guard.category, tc.category); guard.category = tc.category; } changed = true; } assert(tc.knownType.maybe(guard.knownType)); if (tc.knownType < guard.knownType) { // We don't check tc.weak here because knownType is supposed to be // statically known type information. FTRACE(1, "refining knownType of {}: {} -> {}\n", *inst, guard.knownType, tc.knownType); guard.knownType = tc.knownType; } return changed; }
bool IRBuilder::constrainStack(SSATmp* sp, int32_t idx, TypeConstraint tc) { if (!shouldConstrainGuards()) return false; FTRACE(1, "constrainStack({}, {}, {})\n", *sp->inst(), idx, tc); assert(sp->isA(Type::StkPtr)); // We've hit a LdStack. If getStackValue gives us a value, recurse on // that. Otherwise, look at the instruction that gave us the type of the // stack element. If it's a GuardStk or CheckStk, it's our target. If it's // anything else, the value is new so there's no guard to relax. auto stackInfo = getStackValue(sp, idx); if (stackInfo.value) { FTRACE(1, " - value = {}\n", *stackInfo.value->inst()); return constrainValue(stackInfo.value, tc); } else { auto typeSrc = stackInfo.typeSrc; FTRACE(1, " - typeSrc = {}\n", *typeSrc); return typeSrc->is(GuardStk, CheckStk) && constrainGuard(typeSrc, tc); } }
bool IRBuilder::constrainLocal(uint32_t locId, SSATmp* typeSrc, TypeConstraint tc, const std::string& why) { if (!shouldConstrainGuards()) return false; always_assert(IMPLIES(tc.innerCat > DataTypeGeneric, tc.category >= DataTypeCountness)); ITRACE(1, "constrainLocal({}, {}, {}, {})\n", locId, typeSrc ? typeSrc->inst()->toString() : "null", tc, why); Indent _i; if (!typeSrc) return false; if (!typeSrc->isA(Type::FramePtr)) { return constrainValue(typeSrc, tc); } // When typeSrc is a FramePtr, that means we loaded the value the local had // coming into the trace. Trace through the FramePtr chain, looking for a // guard for this local id. If we find it, constrain the guard. If we don't // find it, there wasn't a guard for this local so there's nothing to // constrain. auto guard = guardForLocal(locId, typeSrc); while (guard) { if (guard->is(AssertLoc)) { // If the refined type of the local satisfies the constraint we're // trying to apply, we can stop here. This can happen if we assert a // more general type than what we already know. Otherwise we need to // keep tracing back to the guard. if (typeFitsConstraint(guard->typeParam(), tc)) return false; guard = guardForLocal(locId, guard->src(0)); } else { assert(guard->is(GuardLoc, CheckLoc)); ITRACE(2, "found guard to constrain\n"); return constrainGuard(guard, tc); } } ITRACE(2, "no guard to constrain\n"); return false; }
void TraceBuilder::constrainLocal(uint32_t locId, SSATmp* valSrc, TypeConstraint tc, const std::string& why) { if (!shouldConstrainGuards()) return; FTRACE(1, "constrainLocal({}, {}, {}, {})\n", locId, valSrc ? valSrc->inst()->toString() : "null", tc, why); if (!valSrc) return; if (!valSrc->isA(Type::FramePtr)) { constrainValue(valSrc, tc); return; } // When valSrc is a FramePtr, that means we loaded the value the local had // coming into the trace. Trace through the FramePtr chain, looking for a // guard for this local id. If we find it, constrain the guard. If we don't // find it, there wasn't a guard for this local so there's nothing to // constrain. auto guard = guardForLocal(locId, valSrc); while (guard) { if (guard->is(AssertLoc)) { // If the refined the type of the local satisfies the constraint we're // trying to apply, we can stop here. This can happen if we assert a // more general type than what we already know. Otherwise we need to // keep tracing back to the guard. if (typeFitsConstraint(guard->typeParam(), tc.category)) return; guard = guardForLocal(locId, guard->src(0)); } else { assert(guard->is(GuardLoc, AssertLoc)); FTRACE(2, " - found guard to constrain\n"); constrainGuard(guard, tc); return; } } FTRACE(2, " - no guard to constrain\n"); }
bool IRBuilder::constrainStack(int32_t idx, TypeConstraint tc) { if (!shouldConstrainGuards()) return false; return constrainStack(sp(), idx, tc); }
bool IRBuilder::constrainLocal(uint32_t locId, TypeConstraint tc, const std::string& why) { if (!shouldConstrainGuards()) return false; return constrainLocal(locId, localTypeSource(locId), tc, why); }
/** * Trace back to the guard that provided the type of val, if * any. Constrain it so its type will not be relaxed beyond the given * DataTypeCategory. Returns true iff one or more guard instructions * were constrained. */ bool IRBuilder::constrainValue(SSATmp* const val, TypeConstraint tc) { if (!shouldConstrainGuards()) return false; if (!val) { FTRACE(1, "constrainValue(nullptr, {}), bailing\n", tc); return false; } FTRACE(1, "constrainValue({}, {})\n", *val->inst(), tc); auto inst = val->inst(); if (inst->is(LdLoc, LdLocAddr)) { // We've hit a LdLoc(Addr). If the source of the value is non-null and not // a FramePtr, it's a real value that was killed by a Call. The value won't // be live but it's ok to use it to track down the guard. auto source = inst->extra<LocalData>()->typeSrc; if (!source) { // val was newly created in this trace. Nothing to constrain. FTRACE(2, " - typeSrc is null, bailing\n"); return false; } // If valSrc is a FramePtr, it represents the frame the value was // originally loaded from. Look for the guard for this local. if (source->isA(Type::FramePtr)) { return constrainLocal(inst->extra<LocalId>()->locId, source, tc, "constrainValue"); } // Otherwise, keep chasing down the source of val. return constrainValue(source, tc); } else if (inst->is(LdStack, LdStackAddr)) { return constrainStack(inst->src(0), inst->extra<StackOffset>()->offset, tc); } else if (inst->is(CheckType, AssertType)) { // If the dest type of the instruction fits the constraint we want, we can // stop here without constraining any further. Otherwise, continue through // to the source. auto changed = false; if (inst->is(CheckType)) changed = constrainGuard(inst, tc) || changed; auto dstType = inst->typeParam(); if (!typeFitsConstraint(dstType, tc.category)) { changed = constrainValue(inst->src(0), tc) || changed; } return changed; } else if (inst->is(StRef)) { // StRef requires that src(0) is boxed so we're relying on callers to // appropriately constrain the values they pass to it. Any innerCat in tc // should be applied to the value being stored. tc.category = tc.innerCat; tc.innerCat = DataTypeGeneric; tc.assertedType = Type::Gen; return constrainValue(inst->src(1), tc); } else if (inst->is(Box, BoxPtr, Unbox, UnboxPtr)) { // All Box/Unbox opcodes are similar to StRef/LdRef in some situations and // Mov in others (determined at runtime), so we need to constrain both // outer and inner. auto maxCat = std::max(tc.category, tc.innerCat); tc.category = maxCat; tc.innerCat = maxCat; tc.assertedType = Type::Gen; return constrainValue(inst->src(0), tc); } else if (inst->is(LdRef)) { // Like StRef, we're relying on the caller to have appropriately // constrained the outer type of the box. Constrain the inner type of the // box with tc. tc.innerCat = tc.category; tc.category = DataTypeGeneric; tc.assertedType = Type::Gen; return constrainValue(inst->src(0), tc); } else if (inst->isPassthrough()) { return constrainValue(inst->getPassthroughValue(), tc); } else { // Any instructions not special cased above produce a new value, so // there's no guard for us to constrain. FTRACE(2, " - value is new in this trace, bailing\n"); return false; } // TODO(t2598894): Should be able to do something with LdMem<T> here }
/** * Trace back to the guard that provided the type of val, if * any. Constrain it so its type will not be relaxed beyond the given * DataTypeCategory. Returns true iff one or more guard instructions * were constrained. */ bool TraceBuilder::constrainValue(SSATmp* const val, TypeConstraint tc) { if (!shouldConstrainGuards()) return false; if (!val) { FTRACE(1, "constrainValue(nullptr, {}), bailing\n", tc); return false; } FTRACE(1, "constrainValue({}, {})\n", *val->inst(), tc); auto inst = val->inst(); if (inst->is(LdLoc, LdLocAddr)) { // We've hit a LdLoc(Addr). If the source of the value is non-null and not // a FramePtr, it's a real value that was killed by a Call. The value won't // be live but it's ok to use it to track down the guard. auto source = inst->extra<LocalData>()->valSrc; if (!source) { // val was newly created in this trace. Nothing to constrain. FTRACE(2, " - valSrc is null, bailing\n"); return false; } // If valSrc is a FramePtr, it represents the frame the value was // originally loaded from. Look for the guard for this local. if (source->isA(Type::FramePtr)) { return constrainLocal(inst->extra<LocalId>()->locId, source, tc, "constrainValue"); } // Otherwise, keep chasing down the source of val. return constrainValue(source, tc); } else if (inst->is(LdStack, LdStackAddr)) { return constrainStack(inst->src(0), inst->extra<StackOffset>()->offset, tc); } else if (inst->is(CheckType, AssertType)) { // If the dest type of the instruction fits the constraint we want, we can // stop here without constraining any further. Otherwise, continue through // to the source. auto changed = false; if (inst->is(CheckType)) changed = constrainGuard(inst, tc) || changed; auto dstType = inst->typeParam(); if (!typeFitsConstraint(dstType, tc.category)) { changed = constrainValue(inst->src(0), tc) || changed; } return changed; } else if (inst->is(StRef, StRefNT, Box, BoxPtr)) { // If our caller cares about the inner type, propagate that through. // Otherwise we're done. if (tc.innerCat) { auto src = inst->src(inst->is(StRef, StRefNT) ? 1 : 0); tc.innerCat.reset(); return constrainValue(src, tc); } return false; } else if (inst->is(LdRef, Unbox, UnboxPtr)) { // Pass through to the source of the box, remembering that we care about // the inner type of the box. assert(!tc.innerCat); tc.innerCat = tc.category; return constrainValue(inst->src(0), tc); } else if (inst->isPassthrough()) { return constrainValue(inst->getPassthroughValue(), tc); } else { // Any instructions not special cased above produce a new value, so // there's no guard for us to constrain. FTRACE(2, " - value is new in this trace, bailing\n"); return false; } // TODO(t2598894): Should be able to do something with LdMem<T> here }
/** * Trace back to the guard that provided the type of val, if * any. Constrain it so its type will not be relaxed beyond the given * DataTypeCategory. Returns true iff one or more guard instructions * were constrained. */ bool IRBuilder::constrainValue(SSATmp* const val, TypeConstraint tc) { if (!shouldConstrainGuards()) return false; always_assert(IMPLIES(tc.innerCat > DataTypeGeneric, tc.category >= DataTypeCountness)); if (!val) { ITRACE(1, "constrainValue(nullptr, {}), bailing\n", tc); return false; } ITRACE(1, "constrainValue({}, {})\n", *val->inst(), tc); Indent _i; auto inst = val->inst(); if (inst->is(LdLoc, LdLocAddr)) { // We've hit a LdLoc(Addr). If the source of the value is non-null and not // a FramePtr, it's a real value that was killed by a Call. The value won't // be live but it's ok to use it to track down the guard. auto source = inst->extra<LocalData>()->typeSrc; if (!source) { // val was newly created in this trace. Nothing to constrain. ITRACE(2, "typeSrc is null, bailing\n"); return false; } // If typeSrc is a FramePtr, it represents the frame the value was // originally loaded from. Look for the guard for this local. if (source->isA(Type::FramePtr)) { return constrainLocal(inst->extra<LocalId>()->locId, source, tc, "constrainValue"); } // Otherwise, keep chasing down the source of val. return constrainValue(source, tc); } else if (inst->is(LdStack, LdStackAddr)) { return constrainStack(inst->src(0), inst->extra<StackOffset>()->offset, tc); } else if (inst->is(AssertType)) { // Sometimes code in HhbcTranslator asks for a value with DataTypeSpecific // but can tolerate a less specific value. If that happens, there's nothing // to constrain. if (!typeFitsConstraint(val->type(), tc)) return false; // If the immutable typeParam fits the constraint, we're done. auto const typeParam = inst->typeParam(); if (typeFitsConstraint(typeParam, tc)) return false; auto const newTc = relaxConstraint(tc, typeParam, inst->src(0)->type()); ITRACE(1, "tracing through {}, orig tc: {}, new tc: {}\n", *inst, tc, newTc); return constrainValue(inst->src(0), newTc); } else if (inst->is(CheckType)) { // Sometimes code in HhbcTranslator asks for a value with DataTypeSpecific // but can tolerate a less specific value. If that happens, there's nothing // to constrain. if (!typeFitsConstraint(val->type(), tc)) return false; bool changed = false; auto const typeParam = inst->typeParam(); auto const srcType = inst->src(0)->type(); // Constrain the guard on the CheckType, but first relax the constraint // based on what's known about srcType. auto const guardTc = relaxConstraint(tc, srcType, typeParam); changed = constrainGuard(inst, guardTc) || changed; // Relax typeParam with its current constraint. This is used below to // recursively relax the constraint on the source, if needed. auto constraint = m_guardConstraints[inst]; constraint.category = std::max(constraint.category, guardTc.category); constraint.innerCat = std::max(constraint.innerCat, guardTc.innerCat); auto const knownType = refineType(relaxType(typeParam, constraint), constraint.assertedType); if (!typeFitsConstraint(knownType, tc)) { auto const newTc = relaxConstraint(tc, knownType, srcType); ITRACE(1, "tracing through {}, orig tc: {}, new tc: {}\n", *inst, tc, newTc); changed = constrainValue(inst->src(0), newTc) || changed; } return changed; } else if (inst->is(StRef)) { // StRef requires that src(0) is boxed so we're relying on callers to // appropriately constrain the values they pass to it. Any innerCat in tc // should be applied to the value being stored. tc.category = tc.innerCat; tc.innerCat = DataTypeGeneric; tc.assertedType = Type::Gen; return constrainValue(inst->src(1), tc); } else if (inst->is(Box, BoxPtr, Unbox, UnboxPtr)) { // All Box/Unbox opcodes are similar to StRef/LdRef in some situations and // Mov in others (determined at runtime), so we need to constrain both // outer and inner. auto maxCat = std::max(tc.category, tc.innerCat); tc.category = maxCat; tc.innerCat = maxCat; tc.assertedType = Type::Gen; return constrainValue(inst->src(0), tc); } else if (inst->is(LdRef)) { // Constrain the inner type of the box with tc, using DataTypeCountness for // the outer constraint to preserve the fact that it's a box. tc.innerCat = tc.category; tc.category = DataTypeCountness; tc.assertedType = Type::Gen; return constrainValue(inst->src(0), tc); } else if (inst->isPassthrough()) { return constrainValue(inst->getPassthroughValue(), tc); } else { // Any instructions not special cased above produce a new value, so // there's no guard for us to constrain. ITRACE(2, "value is new in this trace, bailing\n"); return false; } // TODO(t2598894): Should be able to do something with LdMem<T> here }
/* * Performs simplification and CSE on the input instruction. If the input * instruction has a dest, this will return an SSATmp that represents the same * value as dst(0) of the input instruction. If the input instruction has no * dest, this will return nullptr. * * The caller never needs to clone or append; all this has been done. */ SSATmp* IRBuilder::optimizeInst(IRInstruction* inst, CloneFlag doClone, Block* srcBlock, const folly::Optional<IdomVector>& idoms) { static DEBUG_ONLY __thread int instNest = 0; if (debug) ++instNest; SCOPE_EXIT { if (debug) --instNest; }; DEBUG_ONLY auto indent = [&] { return std::string(instNest * 2, ' '); }; auto doCse = [&] (IRInstruction* cseInput) -> SSATmp* { if (m_state.enableCse() && cseInput->canCSE()) { SSATmp* cseResult = m_state.cseLookup(cseInput, srcBlock, idoms); if (cseResult) { // Found a dominating instruction that can be used instead of input FTRACE(1, " {}cse found: {}\n", indent(), cseResult->inst()->toString()); assert(!cseInput->consumesReferences()); if (cseInput->producesReference(0)) { // Replace with an IncRef FTRACE(1, " {}cse of refcount-producing instruction\n", indent()); gen(IncRef, cseResult); } return cseResult; } } return nullptr; }; auto cloneAndAppendOriginal = [&] () -> SSATmp* { if (inst->op() == Nop) return nullptr; if (auto cseResult = doCse(inst)) { return cseResult; } if (doClone == CloneFlag::Yes) { inst = m_unit.cloneInstruction(inst); } appendInstruction(inst); return inst->dst(0); }; // Since some of these optimizations inspect tracked state, we don't // perform any of them on non-main traces. if (m_savedBlocks.size() > 0) return cloneAndAppendOriginal(); // copy propagation on inst source operands copyProp(inst); // First pass of IRBuilder optimizations try to replace an // instruction based on tracked state before we do anything else. // May mutate the IRInstruction in place (and return nullptr) or // return an SSATmp*. if (SSATmp* preOpt = preOptimize(inst)) { FTRACE(1, " {}preOptimize returned: {}\n", indent(), preOpt->inst()->toString()); return preOpt; } if (inst->op() == Nop) return cloneAndAppendOriginal(); if (!m_enableSimplification) { return cloneAndAppendOriginal(); } auto simpResult = m_simplifier.simplify(inst, shouldConstrainGuards()); // These are the possible outputs: // // ([], nullptr): no optimization possible. Use original inst. // // ([], non-nullptr): passing through a src. Don't CSE. // // ([X, ...], Y): throw away input instruction, append 'X, ...' (CSEing // as we go), return Y. if (!simpResult.instrs.empty()) { // New instructions were generated. Append the new ones, filtering out Nops. for (auto* newInst : simpResult.instrs) { assert(!newInst->isTransient()); if (newInst->op() == Nop) continue; auto cseResult = doCse(newInst); if (cseResult) { appendInstruction(m_unit.mov(newInst->dst(), cseResult, newInst->marker())); } else { appendInstruction(newInst); } } return simpResult.dst; } // No new instructions were generated. Either simplification didn't do // anything, or we're using some other instruction's dst instead of our own. if (simpResult.dst) { // We're using some other instruction's output. Don't append anything, and // don't do any CSE. assert(simpResult.dst->inst() != inst); return simpResult.dst; } // No simplification happened. return cloneAndAppendOriginal(); }
bool IRBuilder::constrainStack(SSATmp* sp, int32_t idx, TypeConstraint tc) { if (!shouldConstrainGuards()) return false; always_assert(IMPLIES(tc.innerCat > DataTypeGeneric, tc.category >= DataTypeCountness)); ITRACE(1, "constrainStack({}, {}, {})\n", *sp->inst(), idx, tc); Indent _i; assert(sp->isA(Type::StkPtr)); // We've hit a LdStack. If getStackValue gives us a value, recurse on // that. Otherwise, look at the instruction that gave us the type of the // stack element. If it's a GuardStk or CheckStk, it's our target. If it's // anything else, the value is new so there's no guard to relax. auto stackInfo = getStackValue(sp, idx); // Sometimes code in HhbcTranslator asks for a value with DataTypeSpecific // but can tolerate a less specific value. If that happens, there's nothing // to constrain. if (!typeFitsConstraint(stackInfo.knownType, tc)) return false; IRInstruction* typeSrc = stackInfo.typeSrc; if (stackInfo.value) { ITRACE(1, "value = {}\n", *stackInfo.value->inst()); return constrainValue(stackInfo.value, tc); } else if (typeSrc->is(AssertStk)) { // If the immutable typeParam fits the constraint, we're done. auto const typeParam = typeSrc->typeParam(); if (typeFitsConstraint(typeParam, tc)) return false; auto const srcIdx = typeSrc->extra<StackOffset>()->offset; auto const srcType = getStackValue(typeSrc->src(0), srcIdx).knownType; auto const newTc = relaxConstraint(tc, typeParam, srcType); ITRACE(1, "tracing through {}, orig tc: {}, new tc: {}\n", *typeSrc, tc, newTc); return constrainStack(typeSrc->src(0), srcIdx, newTc); } else if (typeSrc->is(CheckStk)) { auto changed = false; auto const typeParam = typeSrc->typeParam(); auto const srcIdx = typeSrc->extra<StackOffset>()->offset; auto const srcType = getStackValue(typeSrc->src(0), srcIdx).knownType; // Constrain the guard on the CheckType, but first relax the constraint // based on what's known about srcType. auto const guardTc = relaxConstraint(tc, srcType, typeParam); changed = constrainGuard(typeSrc, guardTc) || changed; // Relax typeParam with its current constraint. This is used below to // recursively relax the constraint on the source, if needed. auto constraint = m_guardConstraints[typeSrc]; constraint.category = std::max(constraint.category, guardTc.category); constraint.innerCat = std::max(constraint.innerCat, guardTc.innerCat); auto const knownType = refineType(relaxType(typeParam, constraint), constraint.assertedType); if (!typeFitsConstraint(knownType, tc)) { auto const newTc = relaxConstraint(tc, knownType, srcType); ITRACE(1, "tracing through {}, orig tc: {}, new tc: {}\n", *typeSrc, tc, newTc); changed = constrainStack(typeSrc->src(0), srcIdx, newTc) || changed; } return changed; } else { ITRACE(1, "typeSrc = {}\n", *typeSrc); return typeSrc->is(GuardStk) && constrainGuard(typeSrc, tc); } }