int modify_job_attr(
job *pjob, /* I (modified) */
svrattrl *plist, /* I */
int perm,
int *bad) /* O */
{
int allow_unkn = -1;
long i;
pbs_attribute newattr[JOB_ATR_LAST];
pbs_attribute *pattr;
int rc;
char log_buf[LOCAL_LOG_BUF_SIZE];
pbs_queue *pque;
if ((pque = get_jobs_queue(&pjob)) != NULL)
{
if (pque->qu_qs.qu_type != QTYPE_Execution)
allow_unkn = JOB_ATR_UNKN;
unlock_queue(pque, __func__, NULL, LOGLEVEL);
}
else if (pjob->ji_parent_job != NULL)
{
allow_unkn = JOB_ATR_UNKN;
}
else
{
log_err(PBSE_JOBNOTFOUND, __func__, "Job lost while acquiring queue 5");
return(PBSE_JOBNOTFOUND);
}
pattr = pjob->ji_wattr;
/* call attr_atomic_set to decode and set a copy of the attributes */
rc = attr_atomic_set(
plist, /* I */
pattr, /* I */
newattr, /* O */
job_attr_def, /* I */
JOB_ATR_LAST,
allow_unkn, /* I */
perm, /* I */
bad); /* O */
/* if resource limits are being changed ... */
if ((rc == 0) &&
(newattr[JOB_ATR_resource].at_flags & ATR_VFLAG_SET))
{
if ((perm & (ATR_DFLAG_MGWR | ATR_DFLAG_OPWR)) == 0)
{
/* If job is running, only manager/operator can raise limits */
if (pjob->ji_qs.ji_state == JOB_STATE_RUNNING)
{
long lim = TRUE;
int comp_resc_lt;
get_svr_attr_l(SRV_ATR_QCQLimits, &lim);
comp_resc_lt = comp_resc2(&pjob->ji_wattr[JOB_ATR_resource],
&newattr[JOB_ATR_resource],
lim,
NULL,
LESS);
if (comp_resc_lt != 0)
{
rc = PBSE_PERM;
}
}
/* Also check against queue and system limits */
if (rc == 0)
{
if ((pque = get_jobs_queue(&pjob)) != NULL)
{
rc = chk_resc_limits( &newattr[JOB_ATR_resource], pque, NULL);
unlock_queue(pque, __func__, NULL, LOGLEVEL);
}
else if (pjob == NULL)
{
log_err(PBSE_JOBNOTFOUND, __func__, "Job lost while acquiring queue 6");
return(PBSE_JOBNOTFOUND);
}
else
rc = PBSE_QUENOTAVAILABLE;
}
}
} /* END if ((rc == 0) && ...) */
/* special check on permissions for hold */
if ((rc == 0) &&
(newattr[JOB_ATR_hold].at_flags & ATR_VFLAG_MODIFY))
{
i = newattr[JOB_ATR_hold].at_val.at_long ^
(pattr + JOB_ATR_hold)->at_val.at_long;
rc = chk_hold_priv(i, perm);
}
if (rc == 0)
{
for (i = 0;i < JOB_ATR_LAST;i++)
{
if (newattr[i].at_flags & ATR_VFLAG_MODIFY)
{
if (job_attr_def[i].at_action)
{
rc = job_attr_def[i].at_action(
&newattr[i],
pjob,
ATR_ACTION_ALTER);
if (rc)
break;
}
}
} /* END for (i) */
if ((rc == 0) &&
((newattr[JOB_ATR_userlst].at_flags & ATR_VFLAG_MODIFY) ||
(newattr[JOB_ATR_grouplst].at_flags & ATR_VFLAG_MODIFY)))
{
/* need to reset execution uid and gid */
rc = set_jobexid(pjob, newattr, NULL);
}
if ((rc == 0) &&
(newattr[JOB_ATR_outpath].at_flags & ATR_VFLAG_MODIFY))
{
/* need to recheck if JOB_ATR_outpath is a special case of host only */
if (newattr[JOB_ATR_outpath].at_val.at_str[strlen(newattr[JOB_ATR_outpath].at_val.at_str) - 1] == ':')
{
dynamic_string *ds = get_dynamic_string(-1, NULL);
newattr[JOB_ATR_outpath].at_val.at_str = prefix_std_file(pjob, ds, (int)'o');
/* don't call free_dynamic_string() */
free(ds);
}
/*
* if the output path was specified and ends with a '/'
* then append the standard file name
*/
else if (newattr[JOB_ATR_outpath].at_val.at_str[strlen(newattr[JOB_ATR_outpath].at_val.at_str) - 1] == '/')
{
dynamic_string *ds = get_dynamic_string(-1, NULL);
newattr[JOB_ATR_outpath].at_val.at_str[strlen(newattr[JOB_ATR_outpath].at_val.at_str) - 1] = '\0';
replace_attr_string(&newattr[JOB_ATR_outpath],
(add_std_filename(pjob, newattr[JOB_ATR_outpath].at_val.at_str, (int)'o', ds)));
/* don't call free_dynamic_string because() we still want to use the allocated string */
free(ds);
}
}
if ((rc == 0) &&
(newattr[JOB_ATR_errpath].at_flags & ATR_VFLAG_MODIFY))
{
/* need to recheck if JOB_ATR_errpath is a special case of host only */
if (newattr[JOB_ATR_errpath].at_val.at_str[strlen(newattr[JOB_ATR_errpath].at_val.at_str) - 1] == ':')
{
dynamic_string *ds = get_dynamic_string(-1, NULL);
newattr[JOB_ATR_errpath].at_val.at_str = prefix_std_file(pjob, ds, (int)'e');
/* don't call free_dynamic_string() */
free(ds);
}
/*
* if the error path was specified and ends with a '/'
* then append the standard file name
*/
else if (newattr[JOB_ATR_errpath].at_val.at_str[strlen(newattr[JOB_ATR_errpath].at_val.at_str) - 1] == '/')
{
dynamic_string *ds = get_dynamic_string(-1, NULL);
newattr[JOB_ATR_errpath].at_val.at_str[strlen(newattr[JOB_ATR_errpath].at_val.at_str) - 1] = '\0';
replace_attr_string(&newattr[JOB_ATR_errpath],
(add_std_filename(pjob, newattr[JOB_ATR_errpath].at_val.at_str,(int)'e', ds)));
/* don't call free_dynamic_string() */
free(ds);
}
}
} /* END if (rc == 0) */
if (rc != 0)
{
for (i = 0;i < JOB_ATR_LAST;i++)
job_attr_def[i].at_free(newattr + i);
/* FAILURE */
return(rc);
} /* END if (rc != 0) */
/* OK, now copy the new values into the job attribute array */
for (i = 0;i < JOB_ATR_LAST;i++)
{
if (newattr[i].at_flags & ATR_VFLAG_MODIFY)
{
if (LOGLEVEL >= 7)
{
sprintf(log_buf, "attr %s modified", job_attr_def[i].at_name);
log_event(PBSEVENT_JOB,PBS_EVENTCLASS_JOB,pjob->ji_qs.ji_jobid,log_buf);
}
job_attr_def[i].at_free(pattr + i);
if ((newattr[i].at_type == ATR_TYPE_LIST) ||
(newattr[i].at_type == ATR_TYPE_RESC))
{
list_move(
&newattr[i].at_val.at_list,
&(pattr + i)->at_val.at_list);
}
else
{
*(pattr + i) = newattr[i];
}
(pattr + i)->at_flags = newattr[i].at_flags;
}
} /* END for (i) */
/* note, the newattr[] attributes are on the stack, they go away automatically */
pjob->ji_modified = 1;
return(0);
} /* END modify_job_attr() */
/**
* @brief
* modify_job_attr - modify the attributes of a job automatically
* Used by req_modifyjob() to alter the job attributes and by
* stat_update() [see req_stat.c] to update with latest from MOM
*
* @param[in,out] pjob - job structure
* @param[in,out] plist - Pointer to list of attributes
* @param[in] perm - Permissions of the caller requesting the operation
* @param[out] bad - Pointer to the attribute index in case of a failed
*/
int
modify_job_attr(job *pjob, svrattrl *plist, int perm, int *bad)
{
int changed_resc;
int allow_unkn;
long i;
int modified = 0;
attribute *newattr;
attribute *pre_copy;
attribute *attr_save;
attribute *pattr;
resource *prc;
int rc;
int newstate = -1;
int newsubstate = -1;
long newaccruetype = -1;
if (pjob->ji_qhdr->qu_qs.qu_type == QTYPE_Execution)
allow_unkn = -1;
else
allow_unkn = (int)JOB_ATR_UNKN;
pattr = pjob->ji_wattr;
/* call attr_atomic_set to decode and set a copy of the attributes.
* We need 2 copies: 1 for copying to pattr and 1 for calling the action functions
* We can't use the same copy for the action functions because copying to pattr
* is a shallow copy and array pointers will be cleared during the copy.
*/
newattr = calloc(JOB_ATR_LAST, sizeof(attribute));
if (newattr == NULL)
return PBSE_SYSTEM;
rc = attr_atomic_set(plist, pattr, newattr, job_attr_def, JOB_ATR_LAST,
allow_unkn, perm, bad);
if (rc) {
attr_atomic_kill(newattr, job_attr_def, JOB_ATR_LAST);
return rc;
}
pre_copy = calloc(JOB_ATR_LAST, sizeof(attribute));
if(pre_copy == NULL) {
attr_atomic_kill(newattr, job_attr_def, JOB_ATR_LAST);
return PBSE_SYSTEM;
}
attr_atomic_copy(pre_copy, newattr, job_attr_def, JOB_ATR_LAST);
attr_save = calloc(JOB_ATR_LAST, sizeof(attribute));
if (attr_save == NULL) {
attr_atomic_kill(newattr, job_attr_def, JOB_ATR_LAST);
attr_atomic_kill(pre_copy, job_attr_def, JOB_ATR_LAST);
return PBSE_SYSTEM;
}
attr_atomic_copy(attr_save, pattr, job_attr_def, JOB_ATR_LAST);
/* If resource limits are being changed ... */
changed_resc = newattr[(int)JOB_ATR_resource].at_flags & ATR_VFLAG_SET;
if ((rc == 0) && (changed_resc != 0)) {
/* first, remove ATR_VFLAG_DEFLT from any value which was set */
/* it can no longer be a "default" as it explicitly changed */
prc = (resource *)GET_NEXT(newattr[(int)JOB_ATR_resource].at_val.at_list);
while (prc) {
if ((prc->rs_value.at_flags & (ATR_VFLAG_MODIFY|ATR_VFLAG_DEFLT)) == (ATR_VFLAG_MODIFY|ATR_VFLAG_DEFLT))
prc->rs_value.at_flags &= ~ATR_VFLAG_DEFLT;
if ((prc->rs_value.at_flags & (ATR_VFLAG_MODIFY|ATR_VFLAG_SET)) == (ATR_VFLAG_MODIFY|ATR_VFLAG_SET)) {
/* if being changed at all, see if "select" */
if (prc->rs_defin == pseldef) {
/* select is modified, recalc chunk sums */
rc = set_chunk_sum(&prc->rs_value,
&newattr[(int)JOB_ATR_resource]);
if (rc)
break;
}
}
prc = (resource *)GET_NEXT(prc->rs_link);
}
/* Manager/Operator can modify job just about any old way */
/* So, the following checks are made only if not the Op/Admin */
if ((perm & (ATR_DFLAG_MGWR | ATR_DFLAG_OPWR)) == 0) {
if (pjob->ji_qs.ji_state == JOB_STATE_RUNNING) {
/* regular user cannot raise the limits of a running job */
if ((comp_resc(&pjob->ji_wattr[(int)JOB_ATR_resource],
&newattr[(int)JOB_ATR_resource]) == -1) ||
comp_resc_lt)
rc = PBSE_PERM;
}
/* Also check against queue, system and entity limits */
if (rc == 0) {
rc = chk_resc_limits(&newattr[(int)JOB_ATR_resource],
pjob->ji_qhdr);
}
if (rc == 0) {
rc = check_entity_resc_limit_max(pjob, pjob->ji_qhdr,
&newattr[(int)JOB_ATR_resource]);
if (rc == 0) {
rc = check_entity_resc_limit_queued(pjob, pjob->ji_qhdr,
&newattr[(int)JOB_ATR_resource]);
if (rc == 0)
{
rc = check_entity_resc_limit_max(pjob, NULL,
&newattr[(int)JOB_ATR_resource]);
if (rc == 0)
rc = check_entity_resc_limit_queued(pjob, NULL,
&newattr[(int)JOB_ATR_resource]);
}
}
}
}
}
/* special check on permissions for hold */
if ((rc == 0) &&
(newattr[(int)JOB_ATR_hold].at_flags & ATR_VFLAG_MODIFY)) {
svrattrl *hold_e = find_name_in_svrattrl(plist, ATTR_h);
/* don't perform permission check if Hold_Types attribute */
/* was set in a hook script (special privilege) */
if ((hold_e == NULL) ||
((hold_e->al_flags & ATR_VFLAG_HOOK) == 0)) {
i = newattr[(int)JOB_ATR_hold].at_val.at_long ^
(pattr+(int)JOB_ATR_hold)->at_val.at_long;
rc = chk_hold_priv(i, perm);
}
}
if ((rc == 0) &&
((newattr[(int)JOB_ATR_userlst].at_flags & ATR_VFLAG_MODIFY) ||
(newattr[(int)JOB_ATR_grouplst].at_flags & ATR_VFLAG_MODIFY))) {
/* Need to reset execution uid and gid */
rc = set_objexid((void *)pjob, JOB_OBJECT, newattr);
}
if (rc) {
attr_atomic_kill(newattr, job_attr_def, JOB_ATR_LAST);
attr_atomic_kill(attr_save, job_attr_def, JOB_ATR_LAST);
attr_atomic_kill(pre_copy, job_attr_def, JOB_ATR_LAST);
return (rc);
}
/* OK, if resources changed, reset entity sums */
if (changed_resc) {
account_entity_limit_usages(pjob, NULL,
&newattr[(int)JOB_ATR_resource], INCR, ETLIM_ACC_ALL_RES);
account_entity_limit_usages(pjob, pjob->ji_qhdr,
&newattr[(int)JOB_ATR_resource], INCR, ETLIM_ACC_ALL_RES);
}
/* Now copy the new values into the job attribute array for the purposes of running the action functions */
for (i = 0; i < JOB_ATR_LAST; i++) {
if (newattr[i].at_flags & ATR_VFLAG_MODIFY) {
/*
* The function update_eligible_time() expects it is the only one setting accrue_type.
* If we set it here, it will get confused. There is no action function for accrue_type,
* so pre-setting it for the action function calls isn't required.
*/
if (i == JOB_ATR_accrue_type)
continue;
job_attr_def[i].at_free(&pattr[i]);
if ((pre_copy[i].at_type == ATR_TYPE_LIST) ||
(pre_copy[i].at_type == ATR_TYPE_RESC)) {
list_move(&pre_copy[i].at_val.at_list,
&pattr[i].at_val.at_list);
} else {
pattr[i] = pre_copy[i];
}
/* ATR_VFLAG_MODCACHE will be included if set */
pattr[i].at_flags = pre_copy[i].at_flags;
}
}
for (i = 0; i < JOB_ATR_LAST; i++) {
/* Check newattr instead of pattr for modify. It is possible that
* the attribute already has the modify flag before we added the new attributes to it.
* We only want to call the action functions for attributes which are being modified by this function.
*/
if (newattr[i].at_flags & ATR_VFLAG_MODIFY) {
if ((job_attr_def[i].at_flags & ATR_DFLAG_NOSAVM) == 0)
modified = 1; /* full save to disk for job */
if (job_attr_def[i].at_action) {
rc = job_attr_def[i].at_action(&newattr[i],
pjob, ATR_ACTION_ALTER);
if (rc) {
*bad = i;
break;
}
}
}
}
if (rc) {
attr_atomic_copy(pjob->ji_wattr, attr_save, job_attr_def, JOB_ATR_LAST);
free(pre_copy);
attr_atomic_kill(newattr, job_attr_def, JOB_ATR_LAST);
attr_atomic_kill(attr_save, job_attr_def, JOB_ATR_LAST);
return (rc);
}
/* The action functions may have modified the attributes, need to set them to newattr2 */
for (i = 0; i < JOB_ATR_LAST; i++) {
if (newattr[i].at_flags & ATR_VFLAG_MODIFY) {
job_attr_def[i].at_free(&pattr[i]);
switch (i) {
case JOB_ATR_state:
newstate = state_char2int(newattr[i].at_val.at_char);
break;
case JOB_ATR_substate:
newsubstate = newattr[i].at_val.at_long;
break;
case JOB_ATR_accrue_type:
newaccruetype = newattr[i].at_val.at_long;
break;
default:
if ((newattr[i].at_type == ATR_TYPE_LIST) ||
(newattr[i].at_type == ATR_TYPE_RESC)) {
list_move(&newattr[i].at_val.at_list,
&pattr[i].at_val.at_list);
} else {
pattr[i] = newattr[i];
}
}
/* ATR_VFLAG_MODCACHE will be included if set */
pattr[i].at_flags = newattr[i].at_flags;
}
}
if (newstate != -1 && newsubstate != -1) {
svr_setjobstate(pjob, newstate, newsubstate);
}
if (newaccruetype != -1)
update_eligible_time(newaccruetype, pjob);
if (modified)
pjob->ji_modified = 1; /* an attr was modified, do full save */
free(newattr);
free(pre_copy);
attr_atomic_kill(attr_save, job_attr_def, JOB_ATR_LAST);
return (0);
}
/**
* @brief modify the attributes of a reservation atomically.
*
* @param[in] presv - pointer to the reservation structure.
* @param[in] plist - list of attributes to modify.
* @param[in] perm - permissions.
* @param[out] bad - the index of the attribute which caused an error.
*
* @return 0 on success.
* @return PBS error code.
*/
int
modify_resv_attr(resc_resv *presv, svrattrl *plist, int perm, int *bad)
{
int allow_unkn = 0;
long i = 0;
attribute newattr[(int)RESV_ATR_LAST];
attribute *pattr;
int rc = 0;
if (presv == NULL || plist == NULL)
return PBSE_INTERNAL;
allow_unkn = -1;
pattr = presv->ri_wattr;
/* call attr_atomic_set to decode and set a copy of the attributes */
rc = attr_atomic_set(plist, pattr, newattr, resv_attr_def, RESV_ATR_LAST,
allow_unkn, perm, bad);
if (rc == 0) {
for (i = 0; i < RESV_ATR_LAST; i++) {
if (newattr[i].at_flags & ATR_VFLAG_MODIFY) {
presv->ri_modified = 1; /* an attr was modified, do full save */
if (resv_attr_def[i].at_action) {
rc = resv_attr_def[i].at_action(&newattr[i],
presv, ATR_ACTION_ALTER);
if (rc)
break;
}
}
}
if ((rc == 0) &&
((newattr[(int)RESV_ATR_userlst].at_flags & ATR_VFLAG_MODIFY) ||
(newattr[(int)RESV_ATR_grouplst].at_flags & ATR_VFLAG_MODIFY))) {
/* Need to reset execution uid and gid */
rc = set_objexid((void *)presv, JOB_OBJECT, newattr);
}
}
if (rc) {
for (i = 0; i < RESV_ATR_LAST; i++)
resv_attr_def[i].at_free(newattr+i);
return (rc);
}
/* Now copy the new values into the reservation attribute array */
for (i = 0; i < RESV_ATR_LAST; i++) {
if (newattr[i].at_flags & ATR_VFLAG_MODIFY) {
resv_attr_def[i].at_free(pattr+i);
if ((newattr[i].at_type == ATR_TYPE_LIST) || (newattr[i].at_type == ATR_TYPE_RESC)) {
list_move(&newattr[i].at_val.at_list, &(pattr+i)->at_val.at_list);
} else {
*(pattr+i) = newattr[i];
}
/* ATR_VFLAG_MODCACHE will be included if set */
(pattr+i)->at_flags = newattr[i].at_flags;
}
}
return (0);
}
int modify_job_attr(
job *pjob, /* I (modified) */
svrattrl *plist, /* I */
int perm,
int *bad) /* O */
{
int allow_unkn;
long i;
attribute newattr[(int)JOB_ATR_LAST];
attribute *pattr;
int rc;
if (pjob->ji_qhdr->qu_qs.qu_type == QTYPE_Execution)
allow_unkn = -1;
else
allow_unkn = (int)JOB_ATR_UNKN;
pattr = pjob->ji_wattr;
/* call attr_atomic_set to decode and set a copy of the attributes */
rc = attr_atomic_set(
plist, /* I */
pattr, /* I */
newattr, /* O */
job_attr_def, /* I */
JOB_ATR_LAST,
allow_unkn, /* I */
perm, /* I */
bad); /* O */
/* if resource limits are being changed ... */
if ((rc == 0) &&
(newattr[(int)JOB_ATR_resource].at_flags & ATR_VFLAG_SET))
{
if ((perm & (ATR_DFLAG_MGWR | ATR_DFLAG_OPWR)) == 0)
{
/* If job is running, only manager/operator can raise limits */
if (pjob->ji_qs.ji_state == JOB_STATE_RUNNING)
{
if ((comp_resc2(
&pjob->ji_wattr[(int)JOB_ATR_resource],
&newattr[(int)JOB_ATR_resource],
server.sv_attr[(int)SRV_ATR_QCQLimits].at_val.at_long,
NULL) == -1) ||
(comp_resc_lt != 0))
{
rc = PBSE_PERM;
}
}
/* Also check against queue and system limits */
if (rc == 0)
{
rc = chk_resc_limits(
&newattr[(int)JOB_ATR_resource],
pjob->ji_qhdr,
NULL);
}
}
} /* END if ((rc == 0) && ...) */
/* special check on permissions for hold */
if ((rc == 0) &&
(newattr[(int)JOB_ATR_hold].at_flags & ATR_VFLAG_MODIFY))
{
i = newattr[(int)JOB_ATR_hold].at_val.at_long ^
(pattr + (int)JOB_ATR_hold)->at_val.at_long;
rc = chk_hold_priv(i, perm);
}
if (rc == 0)
{
for (i = 0;i < JOB_ATR_LAST;i++)
{
if (newattr[i].at_flags & ATR_VFLAG_MODIFY)
{
if (job_attr_def[i].at_action)
{
rc = job_attr_def[i].at_action(
&newattr[i],
pjob,
ATR_ACTION_ALTER);
if (rc)
break;
}
}
} /* END for (i) */
if ((rc == 0) &&
((newattr[(int)JOB_ATR_userlst].at_flags & ATR_VFLAG_MODIFY) ||
(newattr[(int)JOB_ATR_grouplst].at_flags & ATR_VFLAG_MODIFY)))
{
/* need to reset execution uid and gid */
rc = set_jobexid(pjob, newattr, NULL);
}
if ((rc == 0) &&
(newattr[(int)JOB_ATR_outpath].at_flags & ATR_VFLAG_MODIFY))
{
/* need to recheck if JOB_ATR_outpath is a special case of host only */
if (newattr[(int)JOB_ATR_outpath].at_val.at_str[strlen(newattr[(int)JOB_ATR_outpath].at_val.at_str) - 1] == ':')
{
newattr[(int)JOB_ATR_outpath].at_val.at_str =
prefix_std_file(pjob, (int)'o');
}
/*
* if the output path was specified and ends with a '/'
* then append the standard file name
*/
else if (newattr[(int)JOB_ATR_outpath].at_val.at_str[strlen(newattr[(int)JOB_ATR_outpath].at_val.at_str) - 1] == '/')
{
newattr[(int)JOB_ATR_outpath].at_val.at_str[strlen(newattr[(int)JOB_ATR_outpath].at_val.at_str) - 1] = '\0';
replace_attr_string(&newattr[(int)JOB_ATR_outpath],
(add_std_filename(pjob,
newattr[(int)JOB_ATR_outpath].at_val.at_str,
(int)'o')));
}
}
if ((rc == 0) &&
(newattr[(int)JOB_ATR_errpath].at_flags & ATR_VFLAG_MODIFY))
{
/* need to recheck if JOB_ATR_errpath is a special case of host only */
if (newattr[(int)JOB_ATR_errpath].at_val.at_str[strlen(newattr[(int)JOB_ATR_errpath].at_val.at_str) - 1] == ':')
{
newattr[(int)JOB_ATR_errpath].at_val.at_str =
prefix_std_file(pjob, (int)'e');
}
/*
* if the error path was specified and ends with a '/'
* then append the standard file name
*/
else if (newattr[(int)JOB_ATR_errpath].at_val.at_str[strlen(newattr[(int)JOB_ATR_errpath].at_val.at_str) - 1] == '/')
{
newattr[(int)JOB_ATR_errpath].at_val.at_str[strlen(newattr[(int)JOB_ATR_errpath].at_val.at_str) - 1] = '\0';
replace_attr_string(&newattr[(int)JOB_ATR_errpath],
(add_std_filename(pjob,
newattr[(int)JOB_ATR_errpath].at_val.at_str,
(int)'e')));
}
}
} /* END if (rc == 0) */
if (rc != 0)
{
for (i = 0;i < JOB_ATR_LAST;i++)
job_attr_def[i].at_free(newattr + i);
/* FAILURE */
return(rc);
} /* END if (rc != 0) */
/* OK, now copy the new values into the job attribute array */
for (i = 0;i < JOB_ATR_LAST;i++)
{
if (newattr[i].at_flags & ATR_VFLAG_MODIFY)
{
if (LOGLEVEL >= 7)
{
sprintf(log_buffer, "attr %s modified",
job_attr_def[i].at_name);
LOG_EVENT(
PBSEVENT_JOB,
PBS_EVENTCLASS_JOB,
pjob->ji_qs.ji_jobid,
log_buffer);
}
job_attr_def[i].at_free(pattr + i);
if ((newattr[i].at_type == ATR_TYPE_LIST) ||
(newattr[i].at_type == ATR_TYPE_RESC))
{
list_move(
&newattr[i].at_val.at_list,
&(pattr + i)->at_val.at_list);
}
else
{
*(pattr + i) = newattr[i];
}
(pattr + i)->at_flags = newattr[i].at_flags;
}
} /* END for (i) */
/* note, the newattr[] attributes are on the stack, they go away automatically */
pjob->ji_modified = 1;
return(0);
} /* END modify_job_attr() */
