void PaintController::checkCachedDisplayItemIsUnchanged(const char* messagePrefix, const DisplayItem& newItem, const DisplayItem& oldItem)
{
ASSERT(RuntimeEnabledFeatures::slimmingPaintUnderInvalidationCheckingEnabled());
ASSERT(!newItem.isCached());
ASSERT(!oldItem.isCached());
if (newItem.skippedCache()) {
showUnderInvalidationError(messagePrefix, "ERROR: under-invalidation: skipped-cache in cached subsequence", &newItem, &oldItem);
ASSERT_NOT_REACHED();
}
if (newItem.isCacheable() && !m_validlyCachedClients.contains(&newItem.client())) {
showUnderInvalidationError(messagePrefix, "ERROR: under-invalidation: invalidated in cached subsequence", &newItem, &oldItem);
ASSERT_NOT_REACHED();
}
if (newItem.equals(oldItem))
return;
showUnderInvalidationError(messagePrefix, "ERROR: under-invalidation: display item changed", &newItem, &oldItem);
#ifndef NDEBUG
if (newItem.isDrawing()) {
RefPtr<const SkPicture> newPicture = static_cast<const DrawingDisplayItem&>(newItem).picture();
RefPtr<const SkPicture> oldPicture = static_cast<const DrawingDisplayItem&>(oldItem).picture();
String oldPictureDebugString = oldPicture ? pictureAsDebugString(oldPicture.get()) : "None";
String newPictureDebugString = newPicture ? pictureAsDebugString(newPicture.get()) : "None";
WTFLogAlways("old picture:\n%s\n", oldPictureDebugString.utf8().data());
WTFLogAlways("new picture:\n%s\n", newPictureDebugString.utf8().data());
}
#endif // NDEBUG
ASSERT_NOT_REACHED();
}
bool PaintChunker::incrementDisplayItemIndex(const DisplayItem& item) {
DCHECK(RuntimeEnabledFeatures::slimmingPaintV2Enabled());
ItemBehavior behavior;
Optional<PaintChunk::Id> newChunkId;
if (DisplayItem::isForeignLayerType(item.getType())) {
behavior = RequiresSeparateChunk;
// Use null chunkId if we are skipping cache, so that the chunk will not
// match any old chunk and will be treated as brand new.
if (!item.skippedCache())
newChunkId.emplace(item.getId());
// Clear m_currentChunkId so that any display items after the foreign layer
// without a new chunk id will be treated as having no id to avoid the chunk
// from using the same id as the chunk before the foreign layer chunk.
m_currentChunkId = WTF::nullopt;
} else {
behavior = DefaultBehavior;
if (!item.skippedCache() && m_currentChunkId)
newChunkId.emplace(*m_currentChunkId);
}
if (m_chunks.isEmpty()) {
PaintChunk newChunk(0, 1, newChunkId ? &*newChunkId : nullptr,
m_currentProperties);
m_chunks.append(newChunk);
m_chunkBehavior.append(behavior);
return true;
}
auto& lastChunk = m_chunks.last();
bool canContinueChunk = m_currentProperties == lastChunk.properties &&
behavior != RequiresSeparateChunk &&
m_chunkBehavior.last() != RequiresSeparateChunk;
if (canContinueChunk) {
lastChunk.endIndex++;
return false;
}
PaintChunk newChunk(lastChunk.endIndex, lastChunk.endIndex + 1,
newChunkId ? &*newChunkId : nullptr, m_currentProperties);
m_chunks.append(newChunk);
m_chunkBehavior.append(behavior);
return true;
}
void DisplayItemList::checkCachedDisplayItemIsUnchanged(const DisplayItem& displayItem, DisplayItemIndicesByClientMap& displayItemIndicesByClient)
{
ASSERT(RuntimeEnabledFeatures::slimmingPaintUnderInvalidationCheckingEnabled());
if (!displayItem.isDrawing() || displayItem.skippedCache() || !clientCacheIsValid(displayItem.client()))
return;
// If checking under-invalidation, we always generate new display item even if the client is not invalidated.
// Checks if the new picture is the same as the cached old picture. If the new picture is different but
// the client is not invalidated, issue error about under-invalidation.
size_t index = findMatchingItemFromIndex(displayItem.nonCachedId(), displayItemIndicesByClient, m_currentDisplayItems);
if (index == kNotFound) {
showUnderInvalidationError("ERROR: under-invalidation: no cached display item", displayItem);
ASSERT_NOT_REACHED();
return;
}
DisplayItems::iterator foundItem = m_currentDisplayItems.begin() + index;
RefPtr<const SkPicture> newPicture = static_cast<const DrawingDisplayItem&>(displayItem).picture();
RefPtr<const SkPicture> oldPicture = static_cast<const DrawingDisplayItem&>(*foundItem).picture();
// Invalidate the display item so that we can check if there are any remaining cached display items after merging.
foundItem->clearClientForUnderInvalidationChecking();
if (!newPicture && !oldPicture)
return;
if (newPicture && oldPicture) {
switch (static_cast<const DrawingDisplayItem&>(displayItem).underInvalidationCheckingMode()) {
case DrawingDisplayItem::CheckPicture:
if (newPicture->approximateOpCount() == oldPicture->approximateOpCount()) {
SkDynamicMemoryWStream newPictureSerialized;
newPicture->serialize(&newPictureSerialized);
SkDynamicMemoryWStream oldPictureSerialized;
oldPicture->serialize(&oldPictureSerialized);
if (newPictureSerialized.bytesWritten() == oldPictureSerialized.bytesWritten()) {
RefPtr<SkData> oldData = adoptRef(oldPictureSerialized.copyToData());
RefPtr<SkData> newData = adoptRef(newPictureSerialized.copyToData());
if (oldData->equals(newData.get()))
return;
}
}
break;
case DrawingDisplayItem::CheckBitmap:
if (newPicture->cullRect() == oldPicture->cullRect()) {
SkBitmap bitmap;
SkRect rect = newPicture->cullRect();
bitmap.allocPixels(SkImageInfo::MakeN32Premul(rect.width(), rect.height()));
SkCanvas canvas(bitmap);
canvas.translate(-rect.x(), -rect.y());
canvas.drawPicture(oldPicture.get());
SkPaint diffPaint;
diffPaint.setXfermodeMode(SkXfermode::kDifference_Mode);
canvas.drawPicture(newPicture.get(), nullptr, &diffPaint);
if (bitmapIsAllZero(bitmap)) // Contents are the same.
return;
}
default:
ASSERT_NOT_REACHED();
}
}
showUnderInvalidationError("ERROR: under-invalidation: display item changed", displayItem);
#ifndef NDEBUG
String oldPictureDebugString = oldPicture ? pictureAsDebugString(oldPicture.get()) : "None";
String newPictureDebugString = newPicture ? pictureAsDebugString(newPicture.get()) : "None";
WTFLogAlways("old picture:\n%s\n", oldPictureDebugString.utf8().data());
WTFLogAlways("new picture:\n%s\n", newPictureDebugString.utf8().data());
#endif // NDEBUG
ASSERT_NOT_REACHED();
}
