static inline T qIterGet(DBusMessageIter *it)
{
T t;
q_dbus_message_iter_get_basic(it, &t);
q_dbus_message_iter_next(it);
return t;
}
static inline T qIterGet(DBusMessageIter *it)
{
// Use a union of expected and largest type q_dbus_message_iter_get_basic
// will return to ensure reading the wrong basic type does not result in
// stack overwrite
union {
// The value to be extracted
T t;
// Largest type that q_dbus_message_iter_get_basic will return
// according to dbus_message_iter_get_basic API documentation
dbus_uint64_t maxValue;
// A pointer to ensure no stack overwrite in case there is a platform
// where sizeof(void*) > sizeof(dbus_uint64_t)
void* ptr;
} value;
// Initialize the value in case a narrower type is extracted to it.
// Note that the result of extracting a narrower type in place of a wider
// one and vice-versa will be platform-dependent.
value.t = T();
q_dbus_message_iter_get_basic(it, &value);
q_dbus_message_iter_next(it);
return value.t;
}
bool QDBusMarshaller::appendCrossMarshalling(QDBusDemarshaller *demarshaller)
{
int code = q_dbus_message_iter_get_arg_type(&demarshaller->iterator);
if (QDBusUtil::isValidBasicType(code)) {
// easy: just append
// do exactly like the D-BUS docs suggest
// (see apidocs for q_dbus_message_iter_get_basic)
qlonglong value;
q_dbus_message_iter_get_basic(&demarshaller->iterator, &value);
q_dbus_message_iter_next(&demarshaller->iterator);
q_dbus_message_iter_append_basic(&iterator, code, &value);
return true;
}
if (code == DBUS_TYPE_ARRAY) {
int element = q_dbus_message_iter_get_element_type(&demarshaller->iterator);
if (QDBusUtil::isValidFixedType(element) && element != DBUS_TYPE_UNIX_FD) {
// another optimization: fixed size arrays
// code is exactly like QDBusDemarshaller::toByteArray
DBusMessageIter sub;
q_dbus_message_iter_recurse(&demarshaller->iterator, &sub);
q_dbus_message_iter_next(&demarshaller->iterator);
int len;
void* data;
q_dbus_message_iter_get_fixed_array(&sub,&data,&len);
char signature[2] = { char(element), 0 };
q_dbus_message_iter_open_container(&iterator, DBUS_TYPE_ARRAY, signature, &sub);
q_dbus_message_iter_append_fixed_array(&sub, element, &data, len);
q_dbus_message_iter_close_container(&iterator, &sub);
return true;
}
}
// We have to recurse
QDBusDemarshaller *drecursed = demarshaller->beginCommon();
QDBusMarshaller mrecursed(capabilities); // create on the stack makes it autoclose
QByteArray subSignature;
const char *sig = 0;
if (code == DBUS_TYPE_VARIANT || code == DBUS_TYPE_ARRAY) {
subSignature = drecursed->currentSignature().toLatin1();
if (!subSignature.isEmpty())
sig = subSignature.constData();
}
open(mrecursed, code, sig);
while (!drecursed->atEnd()) {
if (!mrecursed.appendCrossMarshalling(drecursed)) {
delete drecursed;
return false;
}
}
delete drecursed;
return true;
}
