TEST_F(UtilsTest, IsValidApkPath_Internal) {
// Internal directories
const char *internal1 = TEST_APP_DIR "example.apk";
EXPECT_EQ(0, validate_apk_path(internal1))
<< internal1 << " should be allowed as a valid path";
// b/16888084
const char *path2 = TEST_APP_DIR "example.com/example.apk";
EXPECT_EQ(0, validate_apk_path(path2))
<< path2 << " should be allowed as a valid path";
const char *badint1 = TEST_APP_DIR "../example.apk";
EXPECT_EQ(-1, validate_apk_path(badint1))
<< badint1 << " should be rejected as a invalid path";
const char *badint2 = TEST_APP_DIR "/../example.apk";
EXPECT_EQ(-1, validate_apk_path(badint2))
<< badint2 << " should be rejected as a invalid path";
// Only one subdir should be allowed.
const char *bad_path3 = TEST_APP_DIR "example.com/subdir/pkg.apk";
EXPECT_EQ(-1, validate_apk_path(bad_path3))
<< bad_path3 << " should be rejected as a invalid path";
const char *bad_path4 = TEST_APP_DIR "example.com/subdir/../pkg.apk";
EXPECT_EQ(-1, validate_apk_path(bad_path4))
<< bad_path4 << " should be rejected as a invalid path";
const char *bad_path5 = TEST_APP_DIR "example.com1/../example.com2/pkg.apk";
EXPECT_EQ(-1, validate_apk_path(bad_path5))
<< bad_path5 << " should be rejected as a invalid path";
}
TEST_F(UtilsTest, IsValidApkPath_BadPrefix) {
// Bad prefixes directories
const char *badprefix1 = "/etc/passwd";
EXPECT_EQ(-1, validate_apk_path(badprefix1))
<< badprefix1 << " should be allowed as a valid path";
const char *badprefix2 = "../.." TEST_APP_DIR "../../../blah";
EXPECT_EQ(-1, validate_apk_path(badprefix2))
<< badprefix2 << " should be allowed as a valid path";
const char *badprefix3 = "init.rc";
EXPECT_EQ(-1, validate_apk_path(badprefix3))
<< badprefix3 << " should be allowed as a valid path";
const char *badprefix4 = "/init.rc";
EXPECT_EQ(-1, validate_apk_path(badprefix4))
<< badprefix4 << " should be allowed as a valid path";
}
TEST_F(UtilsTest, IsValidApkPath_Internal) {
// Internal directories
const char *internal1 = TEST_APP_DIR "example.apk";
EXPECT_EQ(0, validate_apk_path(internal1))
<< internal1 << " should be allowed as a valid path";
const char *badint1 = TEST_APP_DIR "../example.apk";
EXPECT_EQ(-1, validate_apk_path(badint1))
<< badint1 << " should be rejected as a invalid path";
const char *badint2 = TEST_APP_DIR "/../example.apk";
EXPECT_EQ(-1, validate_apk_path(badint2))
<< badint2 << " should be rejected as a invalid path";
const char *badint3 = TEST_APP_DIR "example.com/pkg.apk";
EXPECT_EQ(-1, validate_apk_path(badint3))
<< badint3 << " should be rejected as a invalid path";
}
TEST_F(UtilsTest, IsValidApkPath_Private) {
// Internal directories
const char *private1 = TEST_APP_PRIVATE_DIR "example.apk";
EXPECT_EQ(0, validate_apk_path(private1))
<< private1 << " should be allowed as a valid path";
const char *badpriv1 = TEST_APP_PRIVATE_DIR "../example.apk";
EXPECT_EQ(-1, validate_apk_path(badpriv1))
<< badpriv1 << " should be rejected as a invalid path";
const char *badpriv2 = TEST_APP_PRIVATE_DIR "/../example.apk";
EXPECT_EQ(-1, validate_apk_path(badpriv2))
<< badpriv2 << " should be rejected as a invalid path";
const char *badpriv3 = TEST_APP_PRIVATE_DIR "example.com/pkg.apk";
EXPECT_EQ(-1, validate_apk_path(badpriv3))
<< badpriv3 << " should be rejected as a invalid path";
}
int move_dex(const char *src, const char *dst)
{
char src_dex[PKG_PATH_MAX];
char dst_dex[PKG_PATH_MAX];
if (validate_apk_path(src)) return -1;
if (validate_apk_path(dst)) return -1;
if (create_cache_path(src_dex, src)) return -1;
if (create_cache_path(dst_dex, dst)) return -1;
ALOGV("move %s -> %s\n", src_dex, dst_dex);
if (rename(src_dex, dst_dex) < 0) {
ALOGE("Couldn't move %s: %s\n", src_dex, strerror(errno));
return -1;
} else {
return 0;
}
}
int rm_dex(const char *path)
{
char dex_path[PKG_PATH_MAX];
if (validate_apk_path(path)) return -1;
if (create_cache_path(dex_path, path)) return -1;
ALOGV("unlink %s\n", dex_path);
if (unlink(dex_path) < 0) {
ALOGE("Couldn't unlink %s: %s\n", dex_path, strerror(errno));
return -1;
} else {
return 0;
}
}
TEST_F(UtilsTest, IsValidApkPath_TwoSubdirFail) {
const char *badasec7 = TEST_ASEC_DIR "com.example.asec/subdir1/pkg.apk";
EXPECT_EQ(-1, validate_apk_path(badasec7))
<< badasec7 << " should be rejected as a invalid path";
}
TEST_F(UtilsTest, IsValidApkPath_SubdirEscapeSingleFail) {
const char *badasec6 = TEST_ASEC_DIR "com.example.asec/../pkg.apk";
EXPECT_EQ(-1, validate_apk_path(badasec6))
<< badasec6 << " should be rejected as a invalid path";
}
TEST_F(UtilsTest, IsValidApkPath_CrazyDirFail) {
const char *badasec5 = TEST_ASEC_DIR ".//../..";
EXPECT_EQ(-1, validate_apk_path(badasec5))
<< badasec5 << " should be rejected as a invalid path";
}
TEST_F(UtilsTest, IsValidApkPath_SlashEscapeFail) {
const char *badasec4 = TEST_ASEC_DIR "/../example.apk";
EXPECT_EQ(-1, validate_apk_path(badasec4))
<< badasec4 << " should be rejected as a invalid path";
}
TEST_F(UtilsTest, IsValidApkPath_DoubleSlashFail) {
const char *badasec2 = TEST_ASEC_DIR "com.example.asec//pkg.apk";
EXPECT_EQ(-1, validate_apk_path(badasec2))
<< badasec2 << " should be rejected as a invalid path";
}
TEST_F(UtilsTest, IsValidApkPath_AsecGood2) {
const char *asec2 = TEST_ASEC_DIR "com.example.asec/pkg.apk";
EXPECT_EQ(0, validate_apk_path(asec2))
<< asec2 << " should be allowed as a valid path";
}
TEST_F(UtilsTest, IsValidApkPath_AsecGood1) {
const char *asec1 = TEST_ASEC_DIR "example.apk";
EXPECT_EQ(0, validate_apk_path(asec1))
<< asec1 << " should be allowed as a valid path";
}
