void RuleOfTwoSoft::VisitStmt(Stmt *s)
{
CXXOperatorCallExpr *op = dyn_cast<CXXOperatorCallExpr>(s);
if (op) {
FunctionDecl *func = op->getDirectCallee();
if (func && func->getNameAsString() == "operator=") {
CXXMethodDecl *method = dyn_cast<CXXMethodDecl>(func);
if (method && method->getParent()) {
CXXRecordDecl *record = method->getParent();
const bool hasCopyCtor = record->hasNonTrivialCopyConstructor();
const bool hasCopyAssignOp = record->hasNonTrivialCopyAssignment();
if (hasCopyCtor && !hasCopyAssignOp && !isBlacklisted(record)) {
string msg = "Using assign operator but class " + record->getQualifiedNameAsString() + " has copy-ctor but no assign operator";
emitWarning(s->getLocStart(), msg);
}
}
}
} else if (CXXConstructExpr *ctorExpr = dyn_cast<CXXConstructExpr>(s)) {
CXXConstructorDecl *ctorDecl = ctorExpr->getConstructor();
CXXRecordDecl *record = ctorDecl->getParent();
if (ctorDecl->isCopyConstructor() && record) {
const bool hasCopyCtor = record->hasNonTrivialCopyConstructor();
const bool hasCopyAssignOp = record->hasNonTrivialCopyAssignment();
if (!hasCopyCtor && hasCopyAssignOp && !isBlacklisted(record)) {
string msg = "Using copy-ctor but class " + record->getQualifiedNameAsString() + " has a trivial copy-ctor but non trivial assign operator";
emitWarning(s->getLocStart(), msg);
}
}
}
}
void VirtualCallsFromCTOR::VisitDecl(Decl *decl)
{
CXXConstructorDecl *ctorDecl = dyn_cast<CXXConstructorDecl>(decl);
CXXDestructorDecl *dtorDecl = dyn_cast<CXXDestructorDecl>(decl);
if (ctorDecl == nullptr && dtorDecl == nullptr)
return;
Stmt *ctorOrDtorBody = ctorDecl ? ctorDecl->getBody() : dtorDecl->getBody();
if (ctorOrDtorBody == nullptr)
return;
CXXRecordDecl *classDecl = ctorDecl ? ctorDecl->getParent() : dtorDecl->getParent();
std::vector<Stmt*> processedStmts;
SourceLocation loc = containsVirtualCall(classDecl, ctorOrDtorBody, processedStmts);
if (loc.isValid()) {
if (ctorDecl != nullptr) {
emitWarning(decl->getLocStart(), "Calling pure virtual function in CTOR");
} else {
emitWarning(decl->getLocStart(), "Calling pure virtual function in DTOR");
}
emitWarning(loc, "Called here");
}
}
