void recursion(t_opt arg, t_elem *files) { t_elem *cur; cur = files; while (cur) { if (cur->name && cur->path && \ S_ISDIR(cur->st_mode) && \ ft_strcmp(".", cur->name) && \ ft_strcmp("..", cur->name) && \ !(arg.a == 0 && cur->name[0] == '.')) do_recursion(arg, cur->path); cur = cur->next; } }
static int unroll_files_proc (Node *p, void *closure) { int directory_opened = 0; Node *n; struct recursion_frame *frame = (struct recursion_frame *) closure; int err = 0; List *save_dirlist; char *save_update_dir = NULL; struct saved_cwd cwd; char *dir = p->key; /* if this dir was also an explicitly named argument, then skip it. We'll catch it later when we do dirs. */ n = findnode_fn (dirlist, dir); if (n != NULL) return (0); /* otherwise, call dorecusion for this list of files. */ filelist = (List *) p->data; p->data = NULL; save_dirlist = dirlist; dirlist = NULL; if (strcmp(dir, ".") != 0) { if (save_cwd (&cwd)) error_exit (); if ( CVS_CHDIR (dir) < 0) error (1, errno, "could not chdir to %s", dir); save_update_dir = update_dir; update_dir = (char*)xmalloc (strlen (save_update_dir) + strlen (dir) + 5); strcpy (update_dir, save_update_dir); if (*update_dir != '\0') (void) strcat (update_dir, "/"); (void) strcat (update_dir, dir); } if(frame->which&W_LOCAL) { int directory_opened_status=-1; const char *version; const char *tag; const char *date; int nonbranch; char *repository = Name_Repository(NULL,update_dir); ParseTag(&tag, &date, &nonbranch, &version); directory_opened_status=open_directory(repository,".",tag,date,nonbranch,version,current_parsed_root->isremote); if (directory_opened_status!=-1) directory_opened = 1; xfree(repository); xfree(version); xfree(tag); xfree(date); } else { int directory_opened_status=-1; /* we can't simply call Name_Repository() here, if we do we get: -> Name_Repository((null),cvsnt/src) cvs server: in directory cvsnt/src: cvs [server aborted]: CVS directory without administration files present. Cannot continue until this directory is deleted or renamed. */ directory_opened_status=open_directory(NULL,".",NULL,NULL,0,NULL,1); /* We want to open the directory anyway, so treat it as 'remote'. This only affects rlog, etc. */ if (directory_opened_status!=-1) directory_opened = 1; } err += do_recursion (frame, 1); if(directory_opened) close_directory(); if (save_update_dir != NULL) { xfree (update_dir); update_dir = save_update_dir; if (restore_cwd (&cwd, NULL)) error_exit (); free_cwd (&cwd); } dirlist = save_dirlist; if (filelist) dellist (&filelist); return(err); }
/* * Process each of the directories in the list (recursing as we go) */ static int do_dir_proc (Node *p, void *closure) { struct frame_and_entries *frent = (struct frame_and_entries *) closure; struct recursion_frame *frame = frent->frame; struct recursion_frame xframe; char *dir = p->key; char *newrepos, *virtrepos; List *sdirlist; char *srepository; char *smapped_repository; Dtype dir_return = R_PROCESS; Dtype hint; int stripped_dot = 0; int err = 0; struct saved_cwd cwd; char *saved_update_dir; int process_this_directory = 1; int directory_opened = 0; char *old_update_repos = NULL; int directory_not_valid = 0; if (fncmp (dir, CVSADM) == 0 || fncmp (dir, CVSDUMMY) == 0) { /* This seems to most often happen when users (beginning users, generally), try "cvs ci *" or something similar. On that theory, it is possible that we should just silently skip the CVSADM directories, but on the other hand, using a wildcard like this isn't necessarily a practice to encourage (it operates only on files which exist in the working directory, unlike regular CVS recursion). */ /* FIXME-reentrancy: printed_cvs_msg should be in a "command struct" or some such, so that it gets cleared for each new command (this is possible using the remote protocol and a custom-written client). The struct recursion_frame is not far back enough though, some commands (commit at least) will call start_recursion several times. An alternate solution would be to take this whole check and move it to a new function validate_arguments or some such that all the commands call and which snips the offending directory from the argc,argv vector. */ static int printed_cvs_msg = 0; if (!printed_cvs_msg) { error (0, 0, "warning: directory %s specified in argument", dir); error (0, 0, "but CVS uses %s for its own purposes; skipping %s directory", dir, dir); printed_cvs_msg = 1; } return 0; } saved_update_dir = update_dir; update_dir = (char*)xmalloc (strlen (saved_update_dir) + strlen (dir) + 5); strcpy (update_dir, saved_update_dir); /* set up update_dir - skip dots if not at start */ if (strcmp (dir, ".") != 0) { if (update_dir[0] != '\0') { (void) strcat (update_dir, "/"); (void) strcat (update_dir, dir); } else (void) strcpy (update_dir, dir); /* * Here we need a plausible repository name for the sub-directory. We * create one by concatenating the new directory name onto the * previous repository name. The only case where the name should be * used is in the case where we are creating a new sub-directory for * update -d and in that case the generated name will be correct. */ if (repository == NULL) { newrepos = xstrdup (""); virtrepos = xstrdup (""); } else { if(frame->which&W_LOCAL) { char *d=(char*)xmalloc(strlen(dir)+strlen(CVSADM_REP)+32); sprintf(d,"%s/%s",dir,CVSADM_REP); if(isfile(d)) virtrepos = Name_Repository(dir,update_dir); else { virtrepos = (char*)xmalloc (strlen (repository) + strlen (dir) + 5); sprintf (virtrepos, "%s/%s", repository, dir); } xfree(d); } else { virtrepos = (char*)xmalloc (strlen (repository) + strlen (dir) + 5); sprintf (virtrepos, "%s/%s", repository, dir); } if(!current_parsed_root->isremote) { newrepos = map_repository(virtrepos); if(!newrepos) error(1,0,"Internal error - couldn't map %s to anything",virtrepos); } else newrepos = xstrdup(virtrepos); } } else { if (update_dir[0] == '\0') (void) strcpy (update_dir, dir); if (repository == NULL) { newrepos = xstrdup (""); virtrepos = xstrdup (""); } else { newrepos = xstrdup (mapped_repository); virtrepos = xstrdup (repository); } } /* Check to see that the CVSADM directory, if it exists, seems to be well-formed. It can be missing files if the user hit ^C in the middle of a previous run. We want to (a) make this a nonfatal error, and (b) make sure we print which directory has the problem. Do this before the direntproc, so that (1) the direntproc doesn't have to guess/deduce whether we will skip the directory (e.g. send_dirent_proc and whether to send the directory), and (2) so that the warm fuzzy doesn't get printed if we skip the directory. */ if (frame->which & W_LOCAL) { char *cvsadmdir; cvsadmdir = (char*)xmalloc (strlen (dir) + sizeof (CVSADM_REP) + sizeof (CVSADM_ENT) + 80); strcpy (cvsadmdir, dir); strcat (cvsadmdir, "/"); strcat (cvsadmdir, CVSADM); if (isdir (cvsadmdir)) { strcpy (cvsadmdir, dir); strcat (cvsadmdir, "/"); strcat (cvsadmdir, CVSADM_REP); if (!isfile (cvsadmdir)) { /* Some commands like update may have printed "? foo" but if we were planning to recurse, and don't on account of CVS/Repository, we want to say why. */ error (0, 0, "ignoring %s (%s missing)", update_dir, CVSADM_REP); dir_return = R_SKIP_ALL; } /* Likewise for CVS/Entries. */ if (dir_return != R_SKIP_ALL) { strcpy (cvsadmdir, dir); strcat (cvsadmdir, "/"); strcat (cvsadmdir, CVSADM_ENT); if (!isfile (cvsadmdir)) { /* Some commands like update may have printed "? foo" but if we were planning to recurse, and don't on account of CVS/Repository, we want to say why. */ error (0, 0, "ignoring %s (%s missing)", update_dir, CVSADM_ENT); dir_return = R_SKIP_ALL; } } } xfree (cvsadmdir); } /* Only process this directory if the root matches. This nearly duplicates code in do_recursion. */ /* If -d was specified, it should override CVS/Root. In the single-repository case, it is long-standing CVS behavior and makes sense - the user might want another access method, another server (which mounts the same repository), &c. In the multiple-repository case, -d overrides all CVS/Root files. That is the only plausible generalization I can think of. */ if (!(frame->which&W_FAKE) && CVSroot_cmdline == NULL && !server_active) { char *this_root = Name_Root (dir, update_dir); if (this_root != NULL) { if (findnode_fn (root_directories, this_root) == NULL) { /* Add it to our list. */ Node *n = getnode (); n->type = NT_UNKNOWN; n->key = xstrdup (this_root); if (addnode (root_directories, n)) error (1, 0, "cannot add new CVSROOT %s", this_root); } process_this_directory = (fncmp (current_parsed_root->original, this_root) == 0); xfree (this_root); } } /* * Do we have access to this directory? */ if(!current_parsed_root->isremote) { const char *tag=NULL; const char *date=NULL; int nonbranch=0; const char *message; const char *v_msg; /* before we do anything else, see if we have any per-directory tags */ ParseTag (&tag, &date, &nonbranch, NULL); if (! verify_access (frame->permproc, newrepos, NULL, update_dir, frame->tag?frame->tag:tag,&message, &v_msg)) { if(frame->permproc!=verify_read) { if(tag) error (0, 0, "User '%s' cannot %s %s on tag/branch %s", CVS_Username, v_msg, fn_root(virtrepos), tag); else error (0, 0, "User '%s' cannot %s %s", CVS_Username, v_msg, fn_root(virtrepos)); if(message) error(0,0,"%s",message); } dir_return = R_SKIP_ALL; } xfree(tag); xfree(date); } if(dir_return!=R_SKIP_ALL) { /* Generic behavior. I don't see a reason to make the caller specify a direntproc just to get this. */ if ((frame->which & (W_LOCAL|W_FAKE))) { if(!isdir (dir)) hint = R_SKIP_ALL; else hint = R_PROCESS; } else if(!isdir(newrepos)) hint = R_SKIP_ALL; else hint = R_PROCESS; } if (dir_return == R_SKIP_ALL || dir_return == R_ERROR) ; else if(process_this_directory) { int directory_opened_status=-1; const char *dirversion=NULL; const char *dirtag=NULL; const char *dirdate=NULL; int dirnonbranch=0; if(frame->predirentproc != NULL) { frame->predirentproc (frame->callerdat, dir, newrepos, update_dir, frent->entries, virtrepos, hint); } /* before we do anything else, see if we have any per-directory tags */ ParseTag_Dir (dir, &dirtag, &dirdate, &dirnonbranch, &dirversion); directory_opened_status=open_directory(newrepos,dir,dirtag,dirdate,dirnonbranch,dirversion,current_parsed_root->isremote); if (directory_opened_status!=-1) directory_opened = 1; xfree(dirversion); xfree(dirtag); xfree(dirdate); if(!current_parsed_root->isremote) fileattr_startdir(newrepos); } /* call-back dir entry proc (if any) */ if (dir_return == R_SKIP_ALL || dir_return == R_ERROR) ; else if (frame->direntproc != NULL) { /* If we're doing the actual processing, call direntproc. Otherwise, assume that we need to process this directory and recurse. FIXME. */ if (process_this_directory) dir_return = frame->direntproc (frame->callerdat, dir, newrepos, update_dir, frent->entries, virtrepos, hint); else dir_return = R_PROCESS; } else { /* Generic behavior. I don't see a reason to make the caller specify a direntproc just to get this. */ dir_return = hint; } /* only process the dir if the return code was 0 */ if (dir_return != R_SKIP_ALL && dir_return !=R_ERROR) { /* save our current directory and static vars */ if (save_cwd (&cwd)) error_exit (); sdirlist = dirlist; srepository = repository; smapped_repository = mapped_repository; dirlist = NULL; /* cd to the sub-directory */ if (!(frame->which&(W_LOCAL|W_FAKE))) { if ( CVS_CHDIR (newrepos) < 0) { error (1, errno, "could not chdir to %s", fn_root(newrepos)); } } else { if ( !(frame->which&W_FAKE) && CVS_CHDIR (dir) < 0) { if(!noexec) error (1, errno, "could not chdir to %s", fn_root(update_dir)); else directory_not_valid=1; } } old_update_repos = update_repos; update_repos = xstrdup(newrepos); /* honor the global SKIP_DIRS (a.k.a. local) */ if (frame->flags == R_SKIP_DIRS) dir_return = R_SKIP_DIRS; /* remember if the `.' will be stripped for subsequent dirs */ if (strcmp (update_dir, ".") == 0) { update_dir[0] = '\0'; stripped_dot = 1; } /* make the recursive call */ xframe = *frame; xframe.flags = dir_return; if(directory_not_valid) { xframe.which &= ~W_LOCAL; xframe.which |= W_FAKE; } err += do_recursion (&xframe, 0); /* put the `.' back if necessary */ if (stripped_dot) (void) strcpy (update_dir, "."); /* call-back dir leave proc (if any) */ if (process_this_directory && frame->dirleaveproc != NULL) err = frame->dirleaveproc (frame->callerdat, dir, err, update_dir, frent->entries); if(directory_opened) close_directory(); /* get back to where we started and restore state vars */ if (restore_cwd (&cwd, NULL)) error_exit (); xfree(update_repos); update_repos = old_update_repos; free_cwd (&cwd); dirlist = sdirlist; repository = srepository; mapped_repository = smapped_repository; } else { if(directory_opened) close_directory(); fileattr_write(); fileattr_free(); } xfree (newrepos); xfree (virtrepos); xfree (update_dir); update_dir = saved_update_dir; if(dir_return == R_ERROR) err++; return (err); }
/* Start a recursive command. Command line arguments (ARGC, ARGV) dictate the directories and files on which we operate. In the special case of no arguments, we default to ".". */ int start_recursion (FILEPROC fileproc, FILESDONEPROC filesdoneproc, PREDIRENTPROC predirentproc, DIRENTPROC direntproc, DIRLEAVEPROC dirleaveproc, void *callerdat, int argc, char **argv, int local, /* This specifies the kind of recursion. There are several cases: 1. W_LOCAL is not set but W_REPOS is. The current directory when we are called must be the repository and recursion proceeds according to what exists in the repository. 2a. W_LOCAL is set but W_REPOS is not. The current directory when we are called must be the working directory. Recursion proceeds according to what exists in the working directory, never (I think) consulting any part of the repository which does not correspond to the working directory ("correspond" == Name_Repository). 2b. W_LOCAL is set and so is W_REPOS. This is the weird one. The current directory when we are called must be the working directory. We recurse through working directories, but we recurse into a directory if it is exists in the working directory *or* it exists in the repository. If a directory does not exist in the working directory, the direntproc must either tell us to skip it (R_SKIP_ALL), or must create it (I think those are the only two cases). */ int which, int aflag, int readlock, const char *update_preload, const char *repos_preload, int dosrcs, PERMPROC permproc, const char *tag) { int i, err = 0; List *args_to_send_when_finished = NULL; List *files_by_dir = NULL; struct recursion_frame frame; TRACE(3,"start_recursion()"); frame.fileproc = fileproc; frame.filesdoneproc = filesdoneproc; frame.predirentproc = predirentproc; frame.direntproc = direntproc; frame.dirleaveproc = dirleaveproc; frame.callerdat = callerdat; frame.flags = local ? R_SKIP_DIRS : R_PROCESS; frame.which = which; frame.aflag = aflag; frame.readlock = readlock; frame.dosrcs = dosrcs; frame.permproc = permproc; frame.tag = tag; expand_wild (argc, argv, &argc, &argv); if (update_preload == NULL) update_dir = xstrdup (""); else update_dir = xstrdup (update_preload); /* clean up from any previous calls to start_recursion */ xfree (repository); if (filelist) dellist (&filelist); /* FIXME-krp: no longer correct. */ if (dirlist) dellist (&dirlist); update_repos = xstrdup(repos_preload); for (i = 0; i < argc; ++i) { #ifdef SERVER_SUPPORT if (server_active) server_pathname_check (argv[i]); else #endif if(isabsolute(argv[i])) error(1,0,"Absolute filenames not allowed"); } if (argc == 0) { int just_subdirs = (which & W_LOCAL) && !noexec && !isdir (CVSADM); if (!just_subdirs && CVSroot_cmdline == NULL && current_parsed_root->isremote) { char *root = Name_Root (NULL, update_dir); if (root && strcmp (root, current_parsed_root->original) != 0) /* We're skipping this directory because it is for a different root. Therefore, we just want to do the subdirectories only. Processing files would cause a working directory from one repository to be processed against a different repository, which could cause all kinds of spurious conflicts and such. Question: what about the case of "cvs update foo" where we process foo/bar and not foo itself? That seems to be handled somewhere (else) but why should it be a separate case? Needs investigation... */ just_subdirs = 1; xfree (root); } /* * There were no arguments, so we'll probably just recurse. The * exception to the rule is when we are called from a directory * without any CVS administration files. That has always meant to * process each of the sub-directories, so we pretend like we were * called with the list of sub-dirs of the current dir as args */ if (just_subdirs) { dirlist = Find_Directories ((char *) NULL, W_LOCAL, (List *) NULL, NULL); /* If there are no sub-directories, there is a certain logic in favor of doing nothing, but in fact probably the user is just confused about what directory they are in, or whether they cvs add'd a new directory. In the case of at least one sub-directory, at least when we recurse into them we notice (hopefully) whether they are under CVS control. */ if (list_isempty (dirlist) && !noexec) { if (update_dir[0] == '\0') error (0, 0, "in directory .:"); else error (0, 0, "in directory %s:", update_dir); error (1, 0, "there is no version here; run '%s checkout' first", program_name); } else if (current_parsed_root->isremote && server_started) { /* In the the case "cvs update foo bar baz", a call to send_file_names in update.c will have sent the appropriate "Argument" commands to the server. In this case, that won't have happened, so we need to do it here. While this example uses "update", this generalizes to other commands. */ /* This is the same call to Find_Directories as above. FIXME: perhaps it would be better to write a function that duplicates a list. */ args_to_send_when_finished = Find_Directories ((char *) NULL, W_LOCAL, (List *) NULL, NULL); } } else { addlist (&dirlist, "."); } goto do_the_work; } /* * There were arguments, so we have to handle them by hand. To do * that, we set up the filelist and dirlist with the arguments and * call do_recursion. do_recursion recognizes the fact that the * lists are non-null when it starts and doesn't update them. * * explicitly named directories are stored in dirlist. * explicitly named files are stored in filelist. * other possibility is named entities whicha are not currently in * the working directory. */ for (i = 0; i < argc; i++) { /* if this argument is a directory, then add it to the list of directories. */ if (isdir (argv[i])) { strip_trailing_slashes (argv[i]); addlist (&dirlist, argv[i]); } else { /* otherwise, split argument into directory and component names. */ char *dir; char *comp; char *file_to_try; /* Now break out argv[i] into directory part (DIR) and file part (COMP). DIR and COMP will each point to a newly malloc'd string. */ dir = xstrdup (argv[i]); comp = (char*)last_component (dir); if (comp == dir) { /* no dir component. What we have is an implied "./" */ dir = xstrdup("."); } else { char *p = comp; p[-1] = '\0'; comp = xstrdup (p); } /* if this argument exists as a file in the current working directory tree, then add it to the files list. */ if (!(which & W_LOCAL)) { /* If doing rtag, we've done a chdir to the repository. */ file_to_try = (char*)xmalloc (strlen (argv[i]) + sizeof (RCSEXT) + 5); sprintf (file_to_try, "%s%s", argv[i], RCSEXT); } else file_to_try = xstrdup (argv[i]); if (isfile (file_to_try)) { const char *tag; const char *date; int nonbranch; const char *message; const char *v_type; /* before we do anything else, see if we have any per-directory tags */ ParseTag_Dir (dir, &tag, &date, &nonbranch, NULL); if (! verify_access (frame.permproc, dir, file_to_try, update_dir,tag,&message,&v_type)) { if(tag && !quiet && !(which&W_QUIET)) error (0, 0, "User %s is unable to %s %s/%s on branch/tag %s - ignoring",CVS_Username,v_type,dir,file_to_try?file_to_try:"",tag); else if(!quiet && !(which&W_QUIET)) error (0, 0, "User %s is unable to %s %s/%s - ignoring",CVS_Username,v_type,dir,file_to_try?file_to_try:""); if(message && !quiet && !(which&W_QUIET)) error (0, 0, "%s", message); } else { addfile (&files_by_dir, dir, comp); } } else if (isdir (dir)) { if ((which & W_LOCAL) && isdir (CVSADM) && !current_parsed_root->isremote ) { /* otherwise, look for it in the repository. */ char *tmp_update_dir; char *repos; char *reposfile; tmp_update_dir = (char*)xmalloc (strlen (update_dir) + strlen (dir) + 5); strcpy (tmp_update_dir, update_dir); if (*tmp_update_dir != '\0') (void) strcat (tmp_update_dir, "/"); (void) strcat (tmp_update_dir, dir); /* look for it in the repository. */ repos = Name_Repository (dir, tmp_update_dir); reposfile = (char*)xmalloc (strlen (repos) + strlen (comp) + 5); (void) sprintf (reposfile, "%s/%s", repos, comp); xfree (repos); if (isdir (reposfile)) { addlist (&dirlist, argv[i]); } else addfile (&files_by_dir, dir, comp); xfree (tmp_update_dir); xfree (reposfile); } else addfile (&files_by_dir, dir, comp); } else { error (1, 0, "no such directory `%s'", dir); } xfree (file_to_try); xfree (dir); xfree (comp); } } /* At this point we have looped over all named arguments and built a coupla lists. Now we unroll the lists, setting up and calling do_recursion. */ err += walklist (files_by_dir, unroll_files_proc, (void *) &frame); if (files_by_dir) dellist(&files_by_dir); /* then do_recursion on the dirlist. */ if (dirlist != NULL) { do_the_work: err += do_recursion (&frame, 1); } /* Free the data which expand_wild allocated. */ free_names (&argc, argv); xfree (update_dir); xfree (update_repos); if (args_to_send_when_finished != NULL) { /* FIXME (njc): in the multiroot case, we don't want to send argument commands for those top-level directories which do not contain any subdirectories which have files checked out from current_parsed_root->original. If we do, and two repositories have a module with the same name, nasty things could happen. This is hard. Perhaps we should send the Argument commands later in this procedure, after we've had a chance to notice which directores we're using (after do_recursion has been called once). This means a _lot_ of rewriting, however. What we need to do for that to happen is descend the tree and construct a list of directories which are checked out from current_cvsroot. Now, we eliminate from the list all of those directories which are immediate subdirectories of another directory in the list. To say that the opposite way, we keep the directories which are not immediate subdirectories of any other in the list. Here's a picture: a / \ B C / \ D e / \ F G / \ H I The node in capitals are those directories which are checked out from current_cvsroot. We want the list to contain B, C, F, and G. D, H, and I are not included, because their parents are also checked out from current_cvsroot. The algorithm should be: 1) construct a tree of all directory names where each element contains a directory name and a flag which notes if that directory is checked out from current_cvsroot a0 / \ B1 C1 / \ D1 e0 / \ F1 G1 / \ H1 I1 2) Recursively descend the tree. For each node, recurse before processing the node. If the flag is zero, do nothing. If the flag is 1, check the node's parent. If the parent's flag is one, change the current entry's flag to zero. a0 / \ B1 C1 / \ D0 e0 / \ F1 G1 / \ H0 I0 3) Walk the tree and spit out "Argument" commands to tell the server which directories to munge. Yuck. It's not clear this is worth spending time on, since we might want to disable cvs commands entirely from directories that do not have CVSADM files... Anyways, the solution as it stands has modified server.c (dirswitch) to create admin files [via server.c (create_adm_p)] in all path elements for a client's "Directory xxx" command, which forces the server to descend and serve the files there. client.c (send_file_names) has also been modified to send only those arguments which are appropriate to current_parsed_root->original. */ /* Construct a fake argc/argv pair. */ int our_argc = 0, i; char **our_argv = NULL; if (! list_isempty (args_to_send_when_finished)) { Node *head, *p; head = args_to_send_when_finished->list; /* count the number of nodes */ i = 0; for (p = head->next; p != head; p = p->next) i++; our_argc = i; /* create the argument vector */ our_argv = (char **) xmalloc (sizeof (char *) * our_argc); /* populate it */ i = 0; for (p = head->next; p != head; p = p->next) our_argv[i++] = xstrdup (p->key); } /* We don't want to expand widcards, since we've just created a list of directories directly from the filesystem. */ send_file_names (our_argc, our_argv, 0); /* Free our argc/argv. */ if (our_argv != NULL) { for (i = 0; i < our_argc; i++) xfree (our_argv[i]); xfree (our_argv); } if (args_to_send_when_finished) dellist (&args_to_send_when_finished); } return (err); }