static int nvmf_process_property_set(struct spdk_nvmf_conn *conn, struct nvme_qp_tx_desc *tx_desc) { struct spdk_nvmf_fabric_prop_set_rsp *response; struct nvmf_request *req = &tx_desc->req_state; struct spdk_nvmf_fabric_prop_set_cmd *cmd; bool shutdown = false; int ret; cmd = &req->cmd->prop_set_cmd; response = &req->rsp->prop_set_rsp; nvmf_property_set(conn->sess, cmd, response, &shutdown); if (shutdown == true) { SPDK_TRACELOG(SPDK_TRACE_DEBUG, "Call to set properties has indicated shutdown\n"); conn->state = CONN_STATE_FABRIC_DISCONNECT; } /* send the nvmf response if setup by NVMf library */ SPDK_TRACELOG(SPDK_TRACE_DEBUG, "send property set capsule response\n"); ret = spdk_nvmf_send_response(conn, req); if (ret) { SPDK_ERRLOG("Unable to send aq qp tx descriptor\n"); return -1; } return 0; }
static bool nvmf_process_property_set(struct spdk_nvmf_request *req) { struct spdk_nvmf_fabric_prop_set_rsp *response; struct spdk_nvmf_fabric_prop_set_cmd *cmd; bool shutdown = false; cmd = &req->cmd->prop_set_cmd; response = &req->rsp->prop_set_rsp; nvmf_property_set(req->conn->sess, cmd, response, &shutdown); /* TODO: This is not right. It should shut down the whole session. if (shutdown == true) { SPDK_TRACELOG(SPDK_TRACE_DEBUG, "Call to set properties has indicated shutdown\n"); conn->state = CONN_STATE_FABRIC_DISCONNECT; } */ return true; }
static void nvmf_test_property_set(void) { struct nvmf_session *sess; struct spdk_nvmf_fabric_prop_set_cmd cmd; struct spdk_nvmf_fabric_prop_set_rsp response; union spdk_nvme_cc_register *cc; union spdk_nvme_csts_register *csts; union spdk_nvme_aqa_register *aqa; uint32_t nssr; bool shutdown; sess = nvmf_find_session_by_id("subsystem1", SS_SC_CNTLID); #define TEST_PROPERTY_SET(property_name, attr, c_id, union_name, bits_attr, val) \ do {\ BUILD_PROPERTY_CMD(property_name, attr, c_id); \ property_name = (union union_name *)&cmd.value.u32.low; \ property_name->bits.bits_attr = val; \ nvmf_property_set(sess, &cmd, &response, &shutdown); \ CU_ASSERT_EQUAL(response.status.sc, 0); \ CU_ASSERT_EQUAL(sess->vcprop.property_name.bits.bits_attr, val); \ } while (0) TEST_PROPERTY_SET(cc, 0, 31, spdk_nvme_cc_register, en, 1); TEST_PROPERTY_SET(csts, 0, 32, spdk_nvme_csts_register, rdy, 1); TEST_PROPERTY_SET(aqa, 0, 33, spdk_nvme_aqa_register, asqs, 0xf); nssr = 1; cmd.ofst = offsetof(struct spdk_nvmf_ctrlr_properties, nssr); cmd.attrib = 0; cmd.cid = 34; cmd.value.u32.low = nssr; nvmf_property_set(sess, &cmd, &response, &shutdown); CU_ASSERT_EQUAL(response.status.sc, 0); CU_ASSERT_EQUAL(sess->vcprop.nssr, nssr); /* error conditions */ #define TEST_PROPERTY_SET_ERROR(property_name, attr, c_id, union_name, bits_attr, val) \ do {\ BUILD_PROPERTY_CMD(property_name, attr, c_id); \ property_name = (union union_name *)&cmd.value.u32.low; \ property_name->bits.bits_attr = val; \ nvmf_property_set(sess, &cmd, &response, &shutdown); \ CU_ASSERT_EQUAL(response.status.sc, SPDK_NVMF_FABRIC_SC_INVALID_PARAM); \ CU_ASSERT_NOT_EQUAL(sess->vcprop.property_name.bits.bits_attr, val); \ } while (0) TEST_PROPERTY_SET_ERROR(cc, 1, 31, spdk_nvme_cc_register, en, 0); TEST_PROPERTY_SET_ERROR(csts, 1, 32, spdk_nvme_csts_register, rdy, 0); TEST_PROPERTY_SET_ERROR(aqa, 1, 33, spdk_nvme_aqa_register, asqs, 0xe); /* nssr attr = 1 */ nssr = 1; cmd.ofst = offsetof(struct spdk_nvmf_ctrlr_properties, nssr); cmd.attrib = 1; cmd.cid = 37; cmd.value.u32.low = nssr; nvmf_property_set(sess, &cmd, &response, &shutdown); CU_ASSERT_EQUAL(response.status.sc, SPDK_NVMF_FABRIC_SC_INVALID_PARAM); cmd.ofst = 0xffff; cmd.attrib = 0; cmd.value.u32.low = 20; cmd.cid = 35; nvmf_property_set(sess, &cmd, &response, &shutdown); CU_ASSERT_EQUAL(response.status.sc, SPDK_NVMF_FABRIC_SC_INVALID_PARAM); }